tristan/gptel
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

gptel-transient: Set suffix-state explicitly for directives

Browse source 
* gptel-transient.el (gptel-system-prompt--setup): In Transient
v0.5 and up, some suffixes defined dynamically using
`gptel-system-prompt--setup' are being treated as infix commands,
see #140.  Set the `:transient' key of these suffixes to
`transient--do-return' explicitly to avoid this problem.  TODO:
This fix will work but it's not clear why this is needed, this
needs some investigation.
This commit is contained in:
Karthik Chikmagalur 2023-12-25 13:58:23 -08:00
parent 8d3e08faa8
commit c3ca4fd0a0
1 changed files with 9 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
gptel-transient.el
View file

@ -171,17 +171,24 @@ which see."
(cl-incf idx)) (cl-incf idx))
(push pos taken) (push pos taken)
pos) pos)
;; The explicit declaration ":transient transient--do-return" here
;; appears to be required for Transient v0.5 and up. Without it, these
;; are treated as suffixes when invoking `gptel-system-prompt' directly,
;; and infixes when going through `gptel-menu'.
;; TODO: Raise an issue with Transient.
collect (list (key-description key) (capitalize name) collect (list (key-description key) (capitalize name)
`(lambda () (interactive) `(lambda () (interactive)
(message "Directive: %s" ,prompt) (message "Directive: %s" ,prompt)
(setq gptel--system-message ,prompt))) (setq gptel--system-message ,prompt))
:transient 'transient--do-return)
into prompt-suffixes into prompt-suffixes
finally return finally return
(nconc (nconc
(list (list 'gptel--suffix-system-message)) (list (list 'gptel--suffix-system-message))
prompt-suffixes prompt-suffixes
(list (list "SPC" "Pick crowdsourced prompt" (list (list "SPC" "Pick crowdsourced prompt"
'gptel--read-crowdsourced-prompt :transient nil)))))) 'gptel--read-crowdsourced-prompt
:transient nil))))))
(transient-define-prefix gptel-system-prompt () (transient-define-prefix gptel-system-prompt ()
"Change the system prompt to send ChatGPT. "Change the system prompt to send ChatGPT.