tristan/nixinate
1
0
Fork 0
Code Issues 2 Pull requests Projects Releases Packages Wiki Activity

Use explicit cross-platform flock rather than impurely referencing it #30

Merged
MatthewCroughan merged 1 commit from mc/flock-explicit into master 2022-10-26 21:58:29 +00:00
Conversation 6 Commits 1 Files changed 1 +4 -3
MatthewCroughan commented 2022-10-26 21:56:00 +00:00 (Migrated from github.com)
Copy link

This solves #29

This solves #29
Kranzes commented 2022-10-26 22:19:44 +00:00 (Migrated from github.com)
Copy link

Could also use flock from util-linux

Could also use flock from util-linux
MatthewCroughan commented 2022-10-26 22:21:39 +00:00 (Migrated from github.com)
Copy link

@Kranzes Best to avoid locking ourselves into Linux. Right now, technically all of our utilities are not linux specific.

@Kranzes Best to avoid locking ourselves into Linux. Right now, technically all of our utilities are not linux specific.
Kranzes commented 2022-10-26 22:25:06 +00:00 (Migrated from github.com)
Copy link

Does nixos-rebuild work on darwin?

Does nixos-rebuild work on darwin?
MatthewCroughan commented 2022-10-26 22:38:42 +00:00 (Migrated from github.com)
Copy link

@Kranzes No, but I was thinking of having multiple backends, which would solve that problem. So the deployment can be implemented by any backend.

@Kranzes No, but I was thinking of having multiple backends, which would solve that problem. So the deployment can be implemented by any backend.
Gerschtli commented 2022-10-27 13:45:38 +00:00 (Migrated from github.com)
Copy link

I am having trouble with this change because the locally references nix store path of flock is not available on my target machine, resulting in

sudo: /nix/store/wrdk8aqwq7h0lyjglkqgf4x7izd2ymsc-flock-0.2.3/bin/flock: command not found

But I would not be able to call nix store --realise /nix/store/wrdk8aqwq7h0lyjglkqgf4x7izd2ymsc-flock-0.2.3/bin/flock after nix copy with a file lock using flock, some chicken-egg problem here..

Should I create a separate issue for it?

I am having trouble with this change because the locally references nix store path of flock is not available on my target machine, resulting in ``` sudo: /nix/store/wrdk8aqwq7h0lyjglkqgf4x7izd2ymsc-flock-0.2.3/bin/flock: command not found ``` But I would not be able to call `nix store --realise /nix/store/wrdk8aqwq7h0lyjglkqgf4x7izd2ymsc-flock-0.2.3/bin/flock` after `nix copy` with a file lock using `flock`, some chicken-egg problem here.. Should I create a separate issue for it?
MatthewCroughan commented 2022-10-27 13:47:52 +00:00 (Migrated from github.com)
Copy link

@Gerschtli That's interesting, and it should have been caught by my VM Tests, this indicates my VM Tests are not good enough.

@Gerschtli That's interesting, and it should have been caught by my VM Tests, this indicates my VM Tests are not good enough.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: tristan/nixinate#30
No description provided.
Delete branch "mc/flock-explicit"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?