tristan/nixinate
1
0
Fork 0
Code Issues 2 Pull requests Projects Releases Packages Wiki Activity

tests/vmTest: fix and deduplicate code #18

Merged
MatthewCroughan merged 2 commits from mc/fix-tests into master 2022-05-24 03:53:42 +00:00
Conversation 0 Commits 2 Files changed 3 +89 -75
MatthewCroughan commented 2022-05-24 01:41:23 +00:00 (Migrated from github.com)
Copy link

Ironically, I did not properly test that I had made the local and remote tests distinct. So the exampleFlake was hardcoded to 'local' only. So, when building vmTests.local meaning you would get the same results as vmTests.remote, this commit fixes that. Additionally, I've made tests/vmTests/common.nix to deduplicate some of the code between nodes.

Ironically, I did not properly test that I had made the local and remote tests distinct. So the exampleFlake was hardcoded to 'local' only. So, when building vmTests.local meaning you would get the same results as vmTests.remote, this commit fixes that. Additionally, I've made tests/vmTests/common.nix to deduplicate some of the code between nodes.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something isn't working

  
documentation

Improvements or additions to documentation

  
duplicate

This issue or pull request already exists

  
enhancement

New feature or request

  
good first issue

Good for newcomers

  
help wanted

Extra attention is needed

  
invalid

This doesn't seem right

  
question

Further information is requested

  
wontfix

This will not be worked on

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: tristan/nixinate#18
No description provided.
Delete branch "mc/fix-tests"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?